Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev -> master for v1.3.1 #185

Merged
merged 20 commits into from
Oct 27, 2023
Merged

Dev -> master for v1.3.1 #185

merged 20 commits into from
Oct 27, 2023

Conversation

pinin4fjords
Copy link
Member

This is a patch release, mostly for the fix in #183, which was preventing the full tests completing.

I also took the opportunity to make a minor repair to my affiliation in the README, and the release linting prompted some module updates.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

WackerO and others added 20 commits October 24, 2023 15:29
@pinin4fjords pinin4fjords changed the title Dev Dev -> master for v1.3.0 Oct 26, 2023
@github-actions
Copy link

github-actions bot commented Oct 26, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 33e4234

+| ✅ 159 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-26 09:54:55

@pinin4fjords pinin4fjords changed the title Dev -> master for v1.3.0 Dev -> master for v1.3.1 Oct 26, 2023
matthdsm
matthdsm approved these changes Oct 26, 2023
View reviewed changes
Copy link

@matthdsm matthdsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤷🏻

@pinin4fjords
Copy link
Member Author

Thanks @matthdsm !

JoseEspinosa
JoseEspinosa approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@pinin4fjords pinin4fjords merged commit 44c449b into master Oct 27, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

@matthdsm matthdsm matthdsm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pinin4fjords @JoseEspinosa @matthdsm @WackerO