Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump chromap #338

Merged
merged 5 commits into from
Apr 17, 2023
Merged

Bump chromap #338

merged 5 commits into from
Apr 17, 2023

Conversation

JoseEspinosa
Copy link
Member

@JoseEspinosa JoseEspinosa commented Apr 17, 2023

Bump version 0.2.4 of chromap to fix #291 (paired-end bam files were not correctly formatted by chromap and thus, the steps below chromap mapping were excluded in this cases, now enable again).

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@github-actions
Copy link

github-actions bot commented Apr 17, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 261cc86

+| ✅ 157 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-04-17 10:47:32

@JoseEspinosa JoseEspinosa marked this pull request as ready for review April 17, 2023 10:45
@JoseEspinosa JoseEspinosa merged commit 8f4d262 into nf-core:dev Apr 17, 2023
@JoseEspinosa JoseEspinosa deleted the bump_chromap branch September 16, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants