added new flag --reads_in_memory #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FriederikeHanssen
requested changes
May 20, 2021
FriederikeHanssen
approved these changes
May 21, 2021
There was a problem hiding this comment.
This looks great! Thank you for adding it. While you are at it, could you maybe also add a link to the samtools collate fast documentation to --samtools_collate_fast in usage docs? We are not really explaining what it actually does in our docs, and since it might have consequences for the output, it wouldn't hurt I think
|
Feel free to merge this yourself once you are ready :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint .).docsis updatedCHANGELOG.mdis updated