Switch CI to pathogen-repo-ci workflow #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See nextstrain/.github#94 for context
The ingest workflow current runs in <2 minutes so I figured it'd be nice to add as an additional check in the GH Action CI workflow. Copied change made in zika <nextstrain/zika@44f27a5>
4 tasks
genehack
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
In principle great to run the real ingest - but I worry a little about ci failures when NCBI datasets are down - which has happened quite a bit in the past, a couple of days a year.
We could have a flag in ingest that bypasses the call to ncbi-datasets and gets the output files from say s3 to not rely on others for our tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See nextstrain/.github#94 for context
The ingest workflow runs in <2 minutes so I figured it'd be nice to add as an additional check in the GH Action CI workflow.
Copied change made in zika.
Checklist