Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ngettext to handle plurality #1596

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Aug 21, 2024

Follow-up to #1591 (comment)

Checklist

  • Automated checks pass
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs

To be used by other modules.
@victorlin victorlin self-assigned this Aug 21, 2024
@victorlin victorlin mentioned this pull request Aug 21, 2024
4 tasks
Use the same method as "merge: Use singular vs. plural forms as
appropriate in error messages" (9a98647)
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.14%. Comparing base (1e9d131) to head (b06ac37).
Report is 58 commits behind head on master.

Files with missing lines Patch % Lines
augur/filter/_run.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1596      +/-   ##
==========================================
+ Coverage   71.02%   71.14%   +0.11%     
==========================================
  Files          79       79              
  Lines        8256     8273      +17     
  Branches     2003     2010       +7     
==========================================
+ Hits         5864     5886      +22     
+ Misses       2101     2099       -2     
+ Partials      291      288       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@victorlin victorlin marked this pull request as ready for review September 24, 2024 19:57
@victorlin victorlin merged commit bf05db8 into master Sep 24, 2024
30 checks passed
@victorlin victorlin deleted the victorlin/global-ngettext branch September 24, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant