Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed types & singleTextMultipleDest implementation #40

Merged
merged 2 commits into from
Jul 12, 2023
Merged

fix: fixed types & singleTextMultipleDest implementation #40

merged 2 commits into from
Jul 12, 2023

Conversation

maotora
Copy link
Contributor

@maotora maotora commented Jul 11, 2023

This PR reference the issues reported here: #39
I also took the liberty to refractor some interfaces.

alphaolomi
alphaolomi approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@alphaolomi alphaolomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/interfaces/index.ts
}

export interface Message1 {
export interface singleMessageSingleDestination {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use PascalCase
ref:

src/interfaces/index.ts Show resolved Hide resolved
@alphaolomi alphaolomi added the enhancement New feature or request label Jul 12, 2023
@alphaolomi alphaolomi merged commit ee7563e into nextsms:main Jul 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alphaolomi alphaolomi alphaolomi approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maotora @alphaolomi