Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure VMs and regions for 2024-07-01 #5100

Merged
merged 6 commits into from
Jul 2, 2024

Conversation

adamrtalbot
Copy link
Collaborator

@adamrtalbot adamrtalbot commented Jul 1, 2024

Updates the Azure regions and VM sizes using scripts in registry.

Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit a7b81ea
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/6683f1c5ace6010008b9ac92
😎 Deploy Preview https://deploy-preview-5100--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pditommaso
Copy link
Member

All broken! 😆

@adamrtalbot
Copy link
Collaborator Author

memoryInMB vs memoryInMb!!!!

Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
@adamrtalbot adamrtalbot force-pushed the update_azure_regions_vms_2024_07_01 branch from 10194cc to 6f1374c Compare July 1, 2024 17:17
…butes

Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
@pditommaso
Copy link
Member

That's a bit ugly, it may be better to normalise the json files

@pditommaso
Copy link
Member

or just use memoryInMB I don't see memoryInMb any more

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso
Copy link
Member

Did the latter

@adamrtalbot
Copy link
Collaborator Author

or just use memoryInMB I don't see memoryInMb any more

Thought I had checked that but obviously not 🤦

@pditommaso
Copy link
Member

Have you used mv-list-size to generate this? it looks like I'm getting slight different ones

@adamrtalbot
Copy link
Collaborator Author

Have you used mv-list-size to generate this? it looks like I'm getting slight different ones

Yep, used your exact script from master branch (284a660). Perhaps it changes based on the subscription ID?

Signed-off-by: Adam Talbot <12817534+adamrtalbot@users.noreply.github.com>
@adamrtalbot
Copy link
Collaborator Author

Ran script again after using az login to see if it made a difference 🤷

@pditommaso
Copy link
Member

ok, let's merge

@pditommaso pditommaso merged commit 12b027e into master Jul 2, 2024
21 checks passed
@pditommaso pditommaso deleted the update_azure_regions_vms_2024_07_01 branch July 2, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants