Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow requester pays for S3 buckets #5027

Merged
merged 14 commits into from
Jun 10, 2024

Conversation

nathanthorpe
Copy link
Contributor

Allow support for S3 buckets that have requester pays enabled.

Currently you get an access denied message if you try to access one.

@nathanthorpe nathanthorpe requested a review from a team as a code owner May 26, 2024 19:04
Copy link

netlify bot commented May 26, 2024

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 04eaa26
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/6667475635bbf1000875a989
😎 Deploy Preview https://deploy-preview-5027--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nathanthorpe and others added 10 commits May 31, 2024 14:11
Signed-off-by: Nathan Thorpe <nathan@techstormpc.com>
Signed-off-by: Nathan Thorpe <nathan@techstormpc.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Nathan Thorpe <nathan@techstormpc.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Nathan Thorpe <nathan@techstormpc.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Nathan Thorpe <nathan@techstormpc.com>
…ast]

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Nathan Thorpe <nathan@techstormpc.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Nathan Thorpe <nathan@techstormpc.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Nathan Thorpe <nathan@techstormpc.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Nathan Thorpe <nathan@techstormpc.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Nathan Thorpe <nathan@techstormpc.com>
Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I've added a minor suggestion in the docs

docs/config.md Outdated Show resolved Hide resolved
nathanthorpe and others added 2 commits June 10, 2024 11:30
Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Nathan Thorpe <nathan@techstormpc.com>
Signed-off-by: Nathan Thorpe <nathan@techstormpc.com>
@pditommaso pditommaso merged commit 0070c1b into nextflow-io:master Jun 10, 2024
22 checks passed
@nathanthorpe nathanthorpe deleted the allow-requester-pays branch June 10, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants