Charliecloud: registry, docs #5018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
pditommaso
reviewed
May 22, 2024
modules/nextflow/src/main/groovy/nextflow/container/CharliecloudCache.groovy
Outdated
Show resolved
Hide resolved
pditommaso
reviewed
May 22, 2024
modules/nextflow/src/main/groovy/nextflow/container/ContainerHandler.groovy
Show resolved
Hide resolved
Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
pditommaso
reviewed
May 22, 2024
modules/nextflow/src/main/groovy/nextflow/container/CharliecloudCache.groovy
Show resolved
Hide resolved
Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
pditommaso
reviewed
May 22, 2024
modules/nextflow/src/test/groovy/nextflow/container/ContainerHandlerTest.groovy
Show resolved
Hide resolved
…andlerTest.groovy [ci skip] Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
pditommaso
approved these changes
May 22, 2024
|
Ok, thanks |
marcodelapierre
pushed a commit
that referenced
this pull request
May 31, 2024
Signed-off-by: Niklas Schandry <niklas@bio.lmu.de> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that my previous attempt (#4879) at making charliecloud handle the registry does not work. This PR fixes this by following the general approach of other container engines: letting normalizeDockerImageName handle this.
I also realized that my previous PR added three new options for charliecloud, but these were not documented, so this also updates the docs accordingly. This is identical to #5017, except that here I signed off the commits.