Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Platform API endpoint #4855

Merged
merged 6 commits into from
Mar 27, 2024
Merged

Update Platform API endpoint #4855

merged 6 commits into from
Mar 27, 2024

Conversation

marcodelapierre
Copy link
Member

@marcodelapierre marcodelapierre commented Mar 27, 2024

This PR addresses #4813 by

  • updating from api.tower.nf to api.cloud.seqera.io in relevant codebase locations
  • adding a warning message if user provides old API through env variable TOWER_API_ENDPOINT
  • updating unit tests and docs accordingly

@swampie FYI

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 80f776a
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/66043892c4db9200089f60a7
😎 Deploy Preview https://deploy-preview-4855--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@marcodelapierre marcodelapierre self-assigned this Mar 27, 2024
@marcodelapierre marcodelapierre linked an issue Mar 27, 2024 that may be closed by this pull request
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, done. I left some comments

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso
Copy link
Member

@marcodelapierre have a look e3c453e

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso pditommaso merged commit 4842423 into master Mar 27, 2024
4 of 5 checks passed
@pditommaso pditommaso deleted the update/platform_endpoint branch March 27, 2024 15:18
nschan pushed a commit to nschan/nextflow that referenced this pull request Apr 3, 2024
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan pushed a commit to nschan/nextflow that referenced this pull request Apr 3, 2024
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
pditommaso added a commit that referenced this pull request May 28, 2024
Signed-off-by: Dr Marco Claudio De La Pierre <marco.delapierre@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify nf-tower default endpoint to api.cloud.seqera.io
3 participants