Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat HTTP headers as case insensitive #4116

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Treat HTTP headers as case insensitive #4116

merged 2 commits into from
Jul 20, 2023

Conversation

bentsherman
Copy link
Member

Close #4110

@bentsherman
Treat HTTP headers as case insensitive
1e3d38d 
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@netlify
Copy link

netlify bot commented Jul 20, 2023 •
edited
Loading

✅ Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 4fbcb8a
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/64b996cf1857690008d0dbce

@bentsherman
Copy link
Member Author

Also tested with the examples provided in the issue and they work now. The run with the troublesome URL is cached on resume.

@pditommaso
Use case insensitive map [ci fast]
4fbcb8a 
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso
Copy link
Member

While it was perfectly fine, I could resist implementing a version based on map that ignore cases in the key lookup.

The main reason is that formally the http headers are case insensitive; can be misleading requiring to check them in lowercase

@pditommaso pditommaso merged commit 97fd335 into master Jul 20, 2023
17 of 18 checks passed
@pditommaso pditommaso deleted the 4110-http-case-insensitive-headers branch July 20, 2023 20:41
abhi18av pushed a commit to abhi18av/nextflow that referenced this pull request Oct 28, 2023
@bentsherman @pditommaso @abhi18av
Fix Treat HTTP headers as case insensitive (nextflow-io#4116) [ci fast]
d3c9525 

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pditommaso pditommaso Awaiting requested review from pditommaso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP headers should be treated as case-insensitive
2 participants
@bentsherman @pditommaso