Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule to build Nextflow docker image for ARM #4020

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

bentsherman
Copy link
Member

Close #2750

Haven't tested it myself, just drafting a PR for anyone who wants to try a Nextflow docker image on ARM:

cd docker
make build-arm

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Copy link
Member

@mribeirodantas mribeirodantas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Dockerfile remains with the target platform set [by default] to amd64. With this change, I was able to create the container image in my machine (Apple M1).

docker/Makefile Outdated Show resolved Hide resolved
Co-authored-by: Marcel Ribeiro-Dantas <mribeirodantas@seqera.io>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@bentsherman bentsherman marked this pull request as ready for review June 15, 2023 12:33
docker/Makefile Outdated Show resolved Hide resolved
Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@pditommaso pditommaso merged commit 705d55f into master Jun 29, 2023
4 checks passed
@pditommaso pditommaso deleted the 2750-nextflow-docker-arm branch June 29, 2023 15:06
abhi18av pushed a commit to abhi18av/nextflow that referenced this pull request Oct 28, 2023

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Co-authored-by: Marcel Ribeiro-Dantas <mribeirodantas@seqera.io>
Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docker builds on non-ARM architectures
3 participants