Add CPU model name to trace files and traceRecord #3946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrakau
force-pushed
the
add_cpumodel_to_trace2
branch
from
b5c8521
to
9026b23
Compare
|
Wondering if we should integrate this with the |
pditommaso
reviewed
May 25, 2023
modules/nextflow/src/main/groovy/nextflow/trace/TraceRecord.groovy
Outdated
Show resolved
Hide resolved
|
I would expect the |
pditommaso
requested changes
May 25, 2023
Signed-off-by: Sabrina Krakau <sabrinakrakau@gmail.com>
Signed-off-by: mirpedrol <mirp.julia@gmail.com>
Signed-off-by: Sabrina Krakau <sabrinakrakau@gmail.com>
Signed-off-by: Sabrina Krakau <sabrinakrakau@gmail.com>
Signed-off-by: Sabrina Krakau <sabrinakrakau@gmail.com>
skrakau
force-pushed
the
add_cpumodel_to_trace2
branch
from
9026b23
to
6cc161b
Compare
|
Hi, |
Could you have another look at the recent changes @pditommaso ? |
pditommaso
reviewed
Jul 5, 2023
pditommaso
reviewed
Jul 5, 2023
modules/nextflow/src/main/groovy/nextflow/trace/TraceRecord.groovy
Outdated
Show resolved
Hide resolved
…oovy [ci fast] Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
pditommaso
approved these changes
Jul 5, 2023
|
We are ready to go! Thanks for this useful contribution! |
|
Thanks for adding it! |
abhi18av
pushed a commit
to abhi18av/nextflow
that referenced
this pull request
Oct 28, 2023
This commit add the `cpu_model` in the Nextflow trace record. Note: the field is not included in the default trace file, but it can be added by adding in the nextflow config the setting ``` trace.fields = '..,cpu_model' ``` Signed-off-by: Sabrina Krakau <sabrinakrakau@gmail.com> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the CPU model name to the trace files (to allow using this information for a CO2 footprint plugin) and accordingly to the
traceRecord.It is not added to any tests yet.