Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only focus on input if modal is open #1282

Merged
merged 1 commit into from
Aug 14, 2024
Merged

fix: only focus on input if modal is open #1282

merged 1 commit into from
Aug 14, 2024

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Aug 9, 2024

fixes #1257

@enjeck enjeck added the 3. to review Waiting for reviews label Aug 9, 2024
@enjeck enjeck self-assigned this Aug 9, 2024
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough, couldn't find a better solution myself. Not sure why the optional chaining on the function call doesn't work :D

I think to fix the tests it just needs an npm run lint:fix

@juliushaertl
Copy link
Member

juliushaertl commented Aug 14, 2024

Ideally squash the commits into one or use git commit --amend or fixup commits to have a clean git history. That way it is much easier whenever someone needs to refer back to the change which can then be one atomic commit.

Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@juliushaertl juliushaertl merged commit 98704c4 into main Aug 14, 2024
47 checks passed
@juliushaertl juliushaertl deleted the fix/1257 branch August 14, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: this.$el.querySelector is not a function
3 participants