-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure default values show as filled #1176
Conversation
Seems reasonable, just a weird Cypress error. I am assuming it is related since it's affecting the |
I am wondering if instead of filling the default value then we should rather use the placeholder attribute and andjudt the check to allow empty fields for values that have a default? That way a default value would also adapt if changed on the table level. |
I just noticed that this problem also affects other column types, not just the number column. Would look into making this approach more generic |
1225937
to
cc065f2
Compare
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Don't be too hesitant to click the merge button if it is green 😁 |
fixes #993