fix(Backend): use object over loose array for permissions #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
approved these changes
Jul 3, 2024
lib/Db/Table.php
Outdated
| @@ -101,10 +102,9 @@ public function jsonSerialize(): array { | |||
| } | |||
|
|
|||
| /** | |||
| * @psalm-suppress MismatchingDocblockReturnType | |||
| * @return array{read: bool, create: bool, update: bool, delete: bool, manage: bool}|null | |||
| * @return ?Permissions | |||
There was a problem hiding this comment.
No need as we have the type hint already.
There was a problem hiding this comment.
and removed 2, 3 others of the same
Solves issues with undefined array keys, but is said to be more performent but also more clear when coding. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/1131/fix-undefined-key-for-good
branch
from
8079446
to
8086f01
Compare
blizzz
added
4. to release
|
/backport to stable0.7 |
|
The backport to # Switch to the target branch and update it
git checkout stable0.7
git pull origin stable0.7
# Create the new backport branch
git checkout -b backport/1173/stable0.7
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8086f019
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1173/stable0.7Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
/backport to stable0.7 |
|
The backport to # Switch to the target branch and update it
git checkout stable0.7
git pull origin stable0.7
# Create the new backport branch
git checkout -b backport/1173/stable0.7
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8086f019
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1173/stable0.7Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
ok, backport does not work without pulling down more things from main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issues with undefined array keys, but is said to be more performant but also more clear when coding.
fixes #1131