fix(App): unstuck navbar focus on internal entries #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
|
/backport to stable0.7 |
backportbot
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the focus being stuck on the nav bar after switching from Tables to a Tables application. Without the fix, the labels remain to be seen, only a click fixes the state.
Buggy behaviour:
Screencast_20240430_112536.webm
I understand it is OK to refer to app-content-vue as it is already done so in a different place in the same file. Setting the tabIndex is necessary for divs to accept the focus.