-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: Consolidate user/group search code #1025
Conversation
f4c6483
to
ce2a486
Compare
c3f1282
to
8c839ee
Compare
TODO
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
8c839ee
to
5d0404e
Compare
5d0404e
to
30adf50
Compare
ef7e9f2
to
87e80be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that when I initially create a context, I can add users to the user select in the "Share with accounts" / "Share with users" field, but after it is created I cannot add any more users. I can remove users, just not use the select anymore. Same goes for when I try to transfer the context to someone else, I can't use the drop-down select.
I don't get any browser console errors, so if you can't reproduce, may just be a browser thing on my end.
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
48d1010
to
f527f99
Compare
Thanks for testing. I can't reproduce the problem, it works fine for me 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works properly for me now, looks great.
Fixes #1003