Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: Consolidate user/group search code #1025

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Conversation

enjeck
Copy link
Contributor

@enjeck enjeck commented Apr 29, 2024

Fixes #1003

@enjeck enjeck self-assigned this Apr 29, 2024
@enjeck enjeck force-pushed the consolidate-ncselect branch 2 times, most recently from f4c6483 to ce2a486 Compare May 2, 2024 13:51
elzody
elzody previously approved these changes May 6, 2024
@enjeck
Copy link
Contributor Author

enjeck commented May 13, 2024

TODO

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@enjeck enjeck force-pushed the consolidate-ncselect branch 2 times, most recently from ef7e9f2 to 87e80be Compare June 20, 2024 06:59
@enjeck enjeck marked this pull request as ready for review June 20, 2024 13:25
@enjeck enjeck changed the title enh: Move duplicate user/group search code to mixin enh: Consolidate user/group search code Jun 20, 2024
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that when I initially create a context, I can add users to the user select in the "Share with accounts" / "Share with users" field, but after it is created I cannot add any more users. I can remove users, just not use the select anymore. Same goes for when I try to transfer the context to someone else, I can't use the drop-down select.

I don't get any browser console errors, so if you can't reproduce, may just be a browser thing on my end.

@elzody elzody self-requested a review June 21, 2024 14:39
@elzody elzody dismissed their stale review June 21, 2024 14:39

New code since

Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M <patrathewhiz@gmail.com>
@enjeck
Copy link
Contributor Author

enjeck commented Jun 23, 2024

I noticed that when I initially create a context, I can add users to the user select in the "Share with accounts" / "Share with users" field, but after it is created I cannot add any more users. I can remove users, just not use the select anymore. Same goes for when I try to transfer the context to someone else, I can't use the drop-down select.

I don't get any browser console errors, so if you can't reproduce, may just be a browser thing on my end.

Thanks for testing. I can't reproduce the problem, it works fine for me 🤔

@juliushaertl juliushaertl added the 3. to review Waiting for reviews label Jun 26, 2024
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works properly for me now, looks great.

@juliushaertl juliushaertl merged commit da8a088 into main Jun 27, 2024
45 checks passed
@juliushaertl juliushaertl deleted the consolidate-ncselect branch June 27, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Consolidate and resue NcSelects
3 participants