feat(preview): add command to cleanup preview folder #48537
+267
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
added
3. to review
tcitworld
requested review from
nickvergessen,
icewind1991,
skjnldsv and
come-nc
tcitworld
force-pushed
the
add-command-to-cleanup-preview
branch
3 times, most recently
from
d2ab0a7
to
b65598d
Compare
come-nc
reviewed
Oct 3, 2024
When changing preview parameters (size, format, …), one can simply delete the preview folder and run files:scan-app-data in order to retrigger updated preview recreation because files are absent. However, that's not possible when using ObjectStorage as primary storage, as there's no concept of "preview folder". This command allows to simply delete and recreate the preview folder properly from Nextcloud, so that the abstraction levels handle all the subfolder & file deleting part. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
force-pushed
the
add-command-to-cleanup-preview
branch
from
b65598d
to
fe0f89c
Compare
come-nc
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When changing preview parameters (size, format, …), one can simply delete the
appdata_xxx/previewfolder and runfiles:scan-app-datain order to retrigger updated preview recreation because files are absent.However, that's not possible when using ObjectStorage as primary storage, as there's no concept of "preview folder".
This command allows to simply delete and recreate the preview folder properly from Nextcloud, so that the abstraction levels handle all the subfolder & file deleting part.
Possible concerns : deleting all preview files from object storage in a single command might take a while, so even if we don't have a timeout because this is a command, it might be nice to have some kind of a warning before. Possibly a confirmation step.
Checklist