-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(settings): Hide forbidden UI elements for group managers #47589
Conversation
/backport to stable30 |
/backport to stable29 |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
It fixes the issues I reported 🙏
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There you go #47642 |
This comment was marked as resolved.
This comment was marked as resolved.
1. The "recent" accounts API only works for admin and delegated admin -> hide for line managers 2. Line managers can not create new groups -> Hide the UI to add a new group for them 3. Accounts created by line managers require one of the groups, which is managed by the line manager, assigned. So if the line manager only manageres a single group, we should preselect that group. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
8d53984
to
9a8b3de
Compare
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/47589/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9a8b3de2 380b92c0
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47589/stable29 Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..558fbcd
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/47589/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9a8b3de2 380b92c0
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47589/stable30 Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..558fbcd
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
Checklist