Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n: Correct spelling #78

Merged
merged 4 commits into from
Mar 18, 2024
Merged

l10n: Correct spelling #78

merged 4 commits into from
Mar 18, 2024

Conversation

Valdnet
Copy link
Contributor

@Valdnet Valdnet commented Apr 9, 2021

Unify the spelling in applications.

Unify the spelling in applications.
@Valdnet Valdnet requested a review from rakekniven April 9, 2021 10:35
@Valdnet
Copy link
Contributor Author

Valdnet commented Apr 10, 2021

@animalillo @binsky08 Please merge 😉.

@comradekingu
Copy link
Contributor

@Valdnet You want to unify it the other way around to not introduce errors in translation.

@Valdnet
Copy link
Contributor Author

Valdnet commented Apr 11, 2021

@comradekingu I unify words across all Nextcloud apps to avoid spelling mismatches 😉.

@comradekingu
Copy link
Contributor

@Valdnet I get that, but you have picked the strictly less correct variant, and the one that introduces the most errors in translation. There is no way to mark something as terminology to ensure consistent translation on TX, and there isn't a consistency check from what I remember.

Just thought I'd chime in.

@animalillo
Copy link
Collaborator

Since both wordings are correct, and it does seem to spike some shenaningans, i think we will stick with E-mail on this app, thank you though!

@animalillo animalillo closed this Apr 11, 2021
@rakekniven
Copy link
Member

Hello @animalillo. Valdnet spend many hours on github to align the words in many repos to improve the word base at Transifex. He created many PRs the last days and all of them had been merged.
Please see the global target.

@rakekniven rakekniven reopened this Apr 11, 2021
@Valdnet
Copy link
Contributor Author

Valdnet commented Apr 12, 2021

@comradekingu We match the text strings from the main Nextcloud branch. In order for the application to look professional, it is necessary to standardize messages, warnings, descriptions, etc. This is the only way to achieve success.

@rakekniven Thanks for reopening the PR 👍.

@animalillo I am renewing my merge request 😉.

@rakekniven rakekniven mentioned this pull request Dec 18, 2021
@animalillo animalillo merged commit 0358061 into master Mar 18, 2024
1 check failed
@delete-merged-branch delete-merged-branch bot deleted the Valdnet-patch-2 branch March 18, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants