Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CalendarListNew): Public Calendar Modal Opening #6343

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Conversation

SebastianKrupinski
Copy link
Contributor

Resolves: #6341

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 23.73%. Comparing base (6270124) to head (0ae73bc).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...nts/AppNavigation/CalendarList/CalendarListNew.vue 0.00% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6343   +/-   ##
=========================================
  Coverage     23.73%   23.73%           
  Complexity      454      454           
=========================================
  Files           247      247           
  Lines         11731    11729    -2     
  Branches       2223     2213   -10     
=========================================
  Hits           2784     2784           
+ Misses         8626     8625    -1     
+ Partials        321      320    -1     
Flag Coverage Δ
javascript 15.33% <0.00%> (+<0.01%) ⬆️
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GVodyanov
Copy link
Contributor

Told u ESLint wouldn't pass :P

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@GVodyanov GVodyanov merged commit 40eaae5 into main Sep 14, 2024
34 of 35 checks passed
@GVodyanov GVodyanov deleted the fix/issue-6341 branch September 14, 2024 12:49
@GVodyanov
Copy link
Contributor

/backport to stable5.0

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Sep 14, 2024
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Sep 14, 2024
@SebastianKrupinski
Copy link
Contributor Author

Told u ESLint wouldn't pass :P

Lol. Yeah we both new this was the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public calendars are not addabe any more
2 participants