validate app version from info.xml against the tag name in public action #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
validate-app-version
branch
from
5e3403d
to
8704f21
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
validate-app-version
branch
from
8704f21
to
9a2cf83
Compare
|
Example (abbreviated) workflow run with the right tag: https://github.com/icewind1991/security_softening/actions/runs/10938394370 and with the wrong tag: https://github.com/icewind1991/security_softening/actions/runs/10938404441 |
nickvergessen
approved these changes
Sep 19, 2024
skjnldsv
approved these changes
Sep 19, 2024
|
Great Idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks that the tag name matching the version defined in the info.xml.
Mainly intended to prevent accidentally creating a release against the wrong branch.
Fixes #305