Make sets complement each other #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
force-pushed
the
feat/make-sets-complement-each-other
branch
from
2607c8c
to
0cde8b6
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…n they support Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
feat/make-sets-complement-each-other
branch
from
0cde8b6
to
6725df4
Compare
nickvergessen
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each set should build upon the previous one so that to be compatible with 27 only 27 set is needed.
For PHP they use 'UP_TO_' prefixed sets for that but I think we can simply do that directly in default sets.
I removed the ALL set as I do not see the point. We could have a LATEST but I find that dangerous.
I’m starting to think we’re gonna need to start lower than 25 though, to avoid having an unreadable huge set.