Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcListItem): Don't require name prop #6128

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(NcListItem): Don't require name prop #6128

wants to merge 2 commits into from
+3 −11

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Oct 2, 2024

As it is only required if the slot is missing.

@artonge
fix: Don't require name prop in NcListItem
9b85c45 
As it is only required if the slot is missing.

Signed-off-by: Louis <louis@chmn.me>
@artonge artonge self-assigned this Oct 2, 2024
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews labels Oct 2, 2024
ShGKme
ShGKme approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One problem, it is used in computedActionsAriaLabel

@artonge
Copy link
Contributor Author

artonge commented Oct 2, 2024 •
edited
Loading

One problem, it is used in computedActionsAriaLabel

So let's announce it as primarily used for accessibility, and also as fallback for the name slot? And keep it mandatory?

@ShGKme
Copy link
Contributor

ShGKme commented Oct 2, 2024

One problem, it is used in computedActionsAriaLabel

So let's announce it as primarily used for accessibility, and also as fallback for the name slot? And keep it mandatory?

I'd say, we should just simplify computedActionsAriaLabel. We don't need to duplicate location there, especially when it's long. It's a menu in a specific list item and that enough.

@artonge
Copy link
Contributor Author

artonge commented Oct 3, 2024 •
edited
Loading

I'd say, we should just simplify computedActionsAriaLabel. We don't need to duplicate location there, especially when it's long. It's a menu in a specific list item and that enough.

So dropping computedActionsAriaLabel, using actionsAriaLabel directly, and making it required? Not sure what is the state regarding enforcing accessibility properties.

Edit: pushed the mentioned changes.

@artonge
fix: Require actionsAriaLabel in NcListItem
deef42b 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/name_prop_NcListItem branch from 0734559 to deef42b Compare October 3, 2024 12:40
@ShGKme ShGKme requested a review from susnux October 3, 2024 18:06
@ShGKme ShGKme changed the title fix: Don't require name prop in NcListItem fix(NcListItem): Don't require name prop Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

At least 2 approving reviews are required to merge this pull request.

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artonge @ShGKme