fix(NcAppContent): splitpane splitter styles with dark theme #5843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
requested review from
jancborchardt,
juliushaertl,
GretaD and
nimishavijay
18 tasks
ShGKme
approved these changes
Jul 22, 2024
ShGKme
added
bug
juliushaertl
approved these changes
Jul 22, 2024
susnux
approved these changes
Jul 22, 2024
The CSS selectors used for the splitter were no functional, so we were using the default ones from splitpane here. Use our variables for colors to unbreak styling in dark mode. Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/splitpane_style
branch
from
baa89be
to
8cf88c3
Compare
|
/backport to next |
This was referenced Aug 14, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS selectors used for the splitter were no functional, so we were using the default ones from splitpane here.
Use our variables for colors to unbreak styling in dark mode.
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade