fix(NcInputField): Make helper text aligned and maxcontrast color #5822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helper text should be aligned with the input, at least the inline padding should match the input (without icons). Also the helper text without any state (error / success) should be maxcontrast color. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
bug
|
/backport to next |
skjnldsv
approved these changes
Jul 18, 2024
marcoambrosini
approved these changes
Jul 18, 2024
2 tasks
This was referenced Aug 14, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
The helper text should be aligned with the input, at least the inline padding should match the input (without icons).
Also the helper text without any state (error / success) should be maxcontrast color.
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade