Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NcAppSettingsSection: make titles normal h3 size #5819

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

GVodyanov
Copy link
Contributor

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot from 2024-07-17 17-52-36 image

Not sure why their size was limited in the first place

@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Jul 17, 2024
@GVodyanov GVodyanov self-assigned this Jul 17, 2024
@ChristophWurst
Copy link
Contributor

@GVodyanov see nextcloud/server#43393. Until recently, headings in Nextcloud were a bit random

@GVodyanov
Copy link
Contributor Author

@GVodyanov see nextcloud/server#43393. Until recently, headings in Nextcloud were a bit random

So is this PR still relevant or should we wait for someone to come along and standardize this everywhere? @ChristophWurst

@ChristophWurst
Copy link
Contributor

I'd say it is still relevant. The tricky part is to find a solution that works with 28/29 and 30. This lib is compatible with both.

@GVodyanov GVodyanov requested a review from susnux July 18, 2024 08:56
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please adjust the size, otherwise fine :)

@susnux
Copy link
Contributor

susnux commented Jul 18, 2024

/backport to next

Signed-off-by: Grigory V <scratchx@gmx.com>
@GVodyanov GVodyanov force-pushed the style/make-settings-titles-larger branch from 98f16ac to 7fd2ed5 Compare July 19, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants