Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] fix(NcDialog): Ensure the dialog is correctly labelled by its name #5778

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 4, 2024

Backport of #5771

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug Something isn't working enhancement New feature or request 3. to review Waiting for reviews feature: dialog Related to the dialog component labels Jul 4, 2024
@susnux susnux force-pushed the backport/5771/next branch 2 times, most recently from 9534883 to 4aa6709 Compare July 4, 2024 12:14
* Added `labelId` prop to NcModal to allow label modal without a name
* Pass the navigation id (the ID of the headline element of NcDialog) to `labelId`
* Added cypress tests

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the backport/5771/next branch 2 times, most recently from 2596980 to 2cd224a Compare July 7, 2024 12:55
@susnux susnux marked this pull request as ready for review July 7, 2024 12:55
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 74289da into next Jul 9, 2024
18 checks passed
@susnux susnux deleted the backport/5771/next branch July 9, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working enhancement New feature or request feature: dialog Related to the dialog component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants