Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NcRichContenteditable): programmatically show tributes #5674

Merged
merged 1 commit into from
Jun 10, 2024
Merged

feat(NcRichContenteditable): programmatically show tributes #5674

merged 1 commit into from
Jun 10, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Jun 5, 2024 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

slash-command

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@DorraJaouad DorraJaouad self-assigned this Jun 5, 2024
ShGKme
ShGKme requested changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature makes sense

src/components/NcRichContenteditable/NcRichContenteditable.vue Outdated Show resolved Hide resolved
src/components/NcRichContenteditable/NcRichContenteditable.vue Outdated Show resolved Hide resolved
src/components/NcRichContenteditable/NcRichContenteditable.vue Outdated Show resolved Hide resolved
src/components/NcRichContenteditable/NcRichContenteditable.vue Outdated Show resolved Hide resolved
src/components/NcRichContenteditable/NcRichContenteditable.vue Outdated Show resolved Hide resolved
@ShGKme ShGKme added enhancement New feature or request 3. to review Waiting for reviews feature: rich-contenteditable Related to the rich-contenteditable components labels Jun 6, 2024
@ShGKme ShGKme added this to the 8.13.0 milestone Jun 6, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Jun 6, 2024

Remember to add enhancement or bug label for proper CHANGELOG generation :P

@DorraJaouad DorraJaouad force-pushed the feat/programmatic-tribute-show branch 2 times, most recently from 93f0b0c to 742375f Compare June 10, 2024 10:18
@DorraJaouad DorraJaouad force-pushed the feat/programmatic-tribute-show branch from 742375f to 310ac62 Compare June 10, 2024 11:48
@DorraJaouad
feat(NcRichContenteditable): programmatically show tributes
9078ac5 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the feat/programmatic-tribute-show branch from 310ac62 to 9078ac5 Compare June 10, 2024 12:34
@DorraJaouad DorraJaouad merged commit e093132 into master Jun 10, 2024
18 checks passed
@DorraJaouad DorraJaouad deleted the feat/programmatic-tribute-show branch June 10, 2024 13:34
@Antreesy
Copy link
Contributor

/backport to next

@backportbot backportbot bot mentioned this pull request Jun 10, 2024
Merged
@jancborchardt jancborchardt mentioned this pull request Jun 11, 2024
Closed
@susnux susnux mentioned this pull request Jun 20, 2024
Merged
1 task
@susnux susnux mentioned this pull request Jul 3, 2024
Closed
4 tasks
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
This was referenced Aug 14, 2024
Open
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 26, 2024
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux left review comments

@ShGKme ShGKme ShGKme approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
3. to review Waiting for reviews enhancement New feature or request feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Milestone
8.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@DorraJaouad @ShGKme @Antreesy @susnux