Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcAppSidebar): remove hidden navigation toggle from focus trap #5613

Merged
merged 1 commit into from
May 19, 2024
Merged

fix(NcAppSidebar): remove hidden navigation toggle from focus trap #5613

merged 1 commit into from
May 19, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented May 17, 2024

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 Tasks

  • Remove from the focus trap

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme
fix(NcAppSidebar): remove hidden navigation toggle from focus trap
cef507c 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature feature: app-sidebar Related to the app-sidebar component accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels May 17, 2024
@ShGKme ShGKme added this to the 8.12.0 milestone May 17, 2024
@ShGKme ShGKme self-assigned this May 17, 2024
szaimen
szaimen approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks!

@susnux susnux merged commit bc331b3 into master May 19, 2024
18 checks passed
@susnux susnux deleted the fix/hide-nc-app-navigation-toggle-from-focus-trap-on-mobile-sidebar branch May 19, 2024 12:30
@susnux
Copy link
Contributor

susnux commented May 19, 2024

/backport to next

@backportbot backportbot bot mentioned this pull request May 19, 2024
Merged
@susnux susnux mentioned this pull request Jun 20, 2024
Merged
1 task
@susnux susnux mentioned this pull request Jul 3, 2024
Closed
4 tasks
This was referenced Aug 9, 2024
Open
Open
This was referenced Aug 19, 2024
Open
Open
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@szaimen szaimen szaimen approved these changes

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: app-sidebar Related to the app-sidebar component regression Regression of a previous working feature
Projects
None yet
Milestone
8.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @susnux @szaimen