Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

feat(ui): created item display page #2

Merged
merged 9 commits into from
Jun 27, 2023
Merged

feat(ui): created item display page #2

merged 9 commits into from
Jun 27, 2023

Conversation

mauriprado
Copy link
Contributor

No description provided.

@amenes12 amenes12 added the enhancement New feature or request label Jun 8, 2023
Copy link
Contributor

@dalbitresb12 dalbitresb12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the warnings from the Dart analysis workflow and run the auto-formatter. Make sure to add trailing commas to get nice formatting.

Most of the warnings come from using double quotes (") instead of single quotes (') and for not using const constructors, but double check in the workflow results for more info or in your IDE.

android/build.gradle Outdated Show resolved Hide resolved
lib/views/item_view.dart Outdated Show resolved Hide resolved
lib/main.dart Outdated Show resolved Hide resolved
@dalbitresb12
Copy link
Contributor

The PR title is good btw, it's just that the check of it is broken. Pushing new commits will run the fixed version of the PR title checker which should accept the title.

@dalbitresb12 dalbitresb12 changed the title feat(ui): created item display feat(ui): created item display page Jun 9, 2023
dalbitresb12
dalbitresb12 previously approved these changes Jun 27, 2023
Copy link
Contributor

@dalbitresb12 dalbitresb12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did requested changes myself.

Dependencies got auto-updated with the Flutter update
`const` constructors for the `Row` widget were just added in the latest Flutter update
Copy link
Contributor

@dalbitresb12 dalbitresb12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dalbitresb12 dalbitresb12 merged commit e82e847 into main Jun 27, 2023
7 checks passed
@dalbitresb12 dalbitresb12 deleted the feat/item-screen branch June 27, 2023 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants