This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
[v8.x] Backport stringified config improvements as --inspect-new #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This backports #928 to `release/v8` under a new argument name, to prevent it from being a breaking change. This will allow Neutrino 8 users to benefit from the stringifed config improvements sooner, as well as providing a way to compare v8 and v9 configurations. I've not backported the eslint `formatter.__expression` change, since it would require a fair amount of refactoring, increasing risk for little benefit. Fixes #328 for `release/v8`.
eliperelman
approved these changes
Jun 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #928 to
release/v8under a new argument name, to prevent it from being a breaking change. This will allow Neutrino 8 users to benefit from the stringifed config improvements sooner, as well as providing a way to compare v8 and v9 configurations.I've not backported the eslint
formatter.__expressionchange, since it would require a fair amount of refactoring, increasing risk for little benefit.Fixes #328 for
release/v8.