This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Only test against Node 9 on master #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Node 9 job was still scheduled. Might be a Travis bug - have emailed their support. |
eliperelman
approved these changes
May 31, 2018
Since it's very unlikely we're ever going to have a Node 9 only CI failure if Node 8 and Node 10 both pass. This means each PR/branch only uses 2 jobs rather than 3, out of our 5 concurrent job allowance - but yet we still have coverage once they are merged to `master`. Node 9 will also no longer be supported after the end of June.
|
It turns out that for PRs, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's very unlikely we're ever going to have a Node 9 only CI failure if Node 8 and Node 10 both pass. This means each PR/branch only uses 2 jobs rather than 3, out of our 5 concurrent job allowance - but yet we still have coverage once they are merged to
master.Node 9 will also no longer be supported after the end of June.