Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Nest create-new-project under installation and link to it from index #621

Merged
merged 3 commits into from
Dec 21, 2017

Conversation

timkelty
Copy link
Contributor

@timkelty timkelty commented Dec 15, 2017

Thought it made sense for newcomers to see create-project linked to up-front.

Related: #610

Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are other places in docs that reference create-new-project.

@timkelty
Copy link
Contributor Author

Just checked - that was the only place I could find.

@eliperelman
Copy link
Member

Ah I see, I was getting confused with #610. With that now merged, I think the links in there now need to be updated. Sorry!

@timkelty
Copy link
Contributor Author

Ok - rebased off master and applied these changes. Also stole some of the language used in #610 so they match up.

@timkelty
Copy link
Contributor Author

On a side note - I noticed there is no docs/packages/create-project… is that intentional?

@timkelty timkelty closed this Dec 21, 2017
@timkelty timkelty reopened this Dec 21, 2017
@eliperelman
Copy link
Member

@timkelty yes intentional. packages are for middleware, while neutrino and create-project are split out.

Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eliperelman eliperelman merged commit 434fc62 into master Dec 21, 2017
timkelty added a commit to timkelty/neutrino that referenced this pull request Jan 17, 2018
…eutrinojs#621)

* Docs: Nest create-new-project under installation and link to it from index.

* Steal some language from neutrinojs#610

* Link to nested create-new-project
@edmorley edmorley deleted the docs-create-project branch March 9, 2018 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants