This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Remove reliance on babel environments, make babel options merging consistent #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #542. This PR does the following:
env. This makes merging babel configuration from userland a little easier by not making the user updating the options in potentially 2 different places. We fixed this for the test middleware, and this PR fixes it for the build middleware.compile-loaderto merge babel options from higher-level middleware. This was already being done by the react middleware, but the preact middleware wasn't doing this properly. @edmorley brought this to my attention at Fix inconsistencies in the react and preact docs #483 (comment), but I didn't understand the problem at the time. This should now be fixed. Thanks @edmorley!tryblocks that were leftovers from Add option to get package.json content #534. They weren't hurting anything, but it just added a potential point of confusion in the future.