Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

fix eslint-semi-off middleware example #161

Merged
merged 1 commit into from
Apr 4, 2017
Merged

fix eslint-semi-off middleware example #161

merged 1 commit into from
Apr 4, 2017

Conversation

maowug
Copy link
Contributor

@maowug maowug commented Apr 2, 2017

neutrino-preset-airbnb-base looks like below, options to merge should have same structure as neutrino-preset-airbnb-base's ?

(neutrino, options) => {
  neutrino.use(lint, merge({
    eslint: {
      baseConfig: {
        extends: ['airbnb-base']
      },
      rules: {
        // handled by babel rules
        'new-cap': 'off',

        // handled by babel rules
        'object-curly-spacing': 'off',

        // require a capital letter for constructors
        'babel/new-cap': ['error', { newIsCap: true }],

        // require padding inside curly braces
        'babel/object-curly-spacing': ['error', 'always']
      }
    }
  }, options));

@codecov
Copy link

codecov bot commented Apr 2, 2017

Codecov Report

Merging #161 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   90.66%   90.66%           
=======================================
  Files          36       36           
  Lines         418      418           
=======================================
  Hits          379      379           
  Misses         39       39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 230fdf1...c83f6fd. Read the comment docs.

Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@eliperelman eliperelman merged commit e6924e2 into neutrinojs:master Apr 4, 2017
@maowug maowug deleted the patch-1 branch April 4, 2017 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants