Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Allow passed extensions to override defaults #1477

Merged
merged 1 commit into from
Nov 3, 2019
Merged

Allow passed extensions to override defaults #1477

merged 1 commit into from
Nov 3, 2019

Conversation

timkelty
Copy link
Contributor

@timkelty timkelty commented Oct 10, 2019 •
edited
Loading

Fixes #1404

@timkelty timkelty mentioned this pull request Oct 10, 2019
Closed
@edmorley edmorley added the bug label Nov 3, 2019
@edmorley edmorley added this to the Neutrino 9 milestone Nov 3, 2019
@timkelty
Copy link
Contributor Author

timkelty commented Nov 3, 2019 •
edited
Loading

@neutrinojs/core-contributors, @edmorley?

Restarted the CI build, I think it had a network issue.

edmorley
edmorley approved these changes Nov 3, 2019
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - thank you :-)

@edmorley edmorley merged commit a6a0983 into neutrinojs:master Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edmorley edmorley edmorley approved these changes

@eliperelman eliperelman Awaiting requested review from eliperelman

Assignees

@timkelty timkelty

Labels
bug
Milestone
Neutrino 9
Development

Successfully merging this pull request may close these issues.

[v9] options.extensions not used
2 participants
@timkelty @edmorley