Coerce version before parsing major

[timkelty]

With #1366, errors will occur package.json does not contain a fully qualified range (e.g '3', '^3').

TypeError: Invalid Version: 3

TypeError: Invalid Version: ^3

Doing semver.coerce first seems to fix this.

Fixes #1367.
Fixes #1370.

[amorriscode]

@timkelty correct me if I'm wrong but I think it needs to be adjusted here and here as well.

[timkelty]

@amorriscode ah indeed! I'll try and update the PR shortly.

[timkelty]

@amorriscode updated library and node.

@eliperelman if you think adding a Neutrino.getDependencyVersion makes sense instead, I can add it and a test.

  getDependencyVersion(dependency, packageJson = this.options.packageJson) {
    const { dependencies = {}, devDependencies = {} } = packageJson || {};

    return (
      (dependency in dependencies || dependency in devDependencies) &&
      semver.coerce(dependencies[dependency] || devDependencies[dependency])
    );
  }

[eliperelman]

@timkelty I think that solution looks good, although I'm not sure why we would want the packageJson argument. Go for it!

[timkelty]

although I'm not sure why we would want the packageJson

@eliperelman yeah no real application for that, other than maybe for tests at some point. I can leave it out until/if we need it.

[timkelty]

Ok - Neutrino.getDependencyVersion is now implemented, used by relevant middleware, and has a test.

[eliperelman]

🎉