Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards-compatibility of imports broken after refactoring #85

Closed
matjobst opened this issue Mar 26, 2024 · 1 comment · Fixed by #86
Closed

Backwards-compatibility of imports broken after refactoring #85

matjobst opened this issue Mar 26, 2024 · 1 comment · Fixed by #86
Assignees

Comments

@matjobst
Copy link
Collaborator

matjobst commented Mar 26, 2024

After the refactoring #78 , the code structure of NIR changed.

Many libraries were using imports such as

from nir import NIRNode

However this fails now as NIRNode is not visible anymore. The solution should be to add it to the list of imports in the __init__.py that looks something like this:

from nir.node import NIRNode
...
__all__ = ["NIRNode", ...]

This would allow the simpler imports again.

@matjobst
Copy link
Collaborator Author

Actually the NIRNode just seems to be missing in __all__ and __all_ir of nir/ir/__init__.py

@matjobst matjobst self-assigned this Mar 26, 2024
matjobst added a commit that referenced this issue Mar 26, 2024
matjobst added a commit that referenced this issue Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant