Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for discriminator #971

Merged
merged 10 commits into from
Feb 16, 2024
Merged

Fixes for discriminator #971

merged 10 commits into from
Feb 16, 2024

Conversation

justin-tay
Copy link
Contributor

Closes #609, closes #588

This fixes issues with the discriminator and also adds support for processing in oneOf.

@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (2879ca3) 78.59% compared to head (391125e) 78.67%.

Files Patch % Lines
...a/com/networknt/schema/DiscriminatorValidator.java 76.19% 2 Missing and 3 partials ⚠️
...main/java/com/networknt/schema/OneOfValidator.java 86.66% 0 Missing and 4 partials ⚠️
...main/java/com/networknt/schema/JsonMetaSchema.java 80.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #971      +/-   ##
============================================
+ Coverage     78.59%   78.67%   +0.07%     
- Complexity     1810     1835      +25     
============================================
  Files           161      162       +1     
  Lines          5887     5941      +54     
  Branches       1119     1138      +19     
============================================
+ Hits           4627     4674      +47     
- Misses          833      835       +2     
- Partials        427      432       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit bd085ed into networknt:master Feb 16, 2024
4 checks passed
@justin-tay justin-tay deleted the gh609 branch February 20, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discriminator not working with arrays anyOf fails when config enabled but discriminator not defined
3 participants