Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory usage and improve performance #966

Merged
merged 16 commits into from
Feb 13, 2024

Conversation

justin-tay
Copy link
Contributor

This reduces memory usage and improves performance in particular when a lot of assertions are generated, typically with a large input data set and with the use of oneOf. In such cases the application may hang as it attempts to repeatedly aggregate the assertions into the LinkedHashSet.

@codecov-commenter
Copy link

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (c768bc1) 78.78% compared to head (5b30462) 78.63%.

Files Patch % Lines
.../main/java/com/networknt/schema/utils/SetView.java 76.92% 8 Missing and 10 partials ⚠️
...va/com/networknt/schema/DependenciesValidator.java 80.00% 0 Missing and 2 partials ⚠️
...in/java/com/networknt/schema/DependentSchemas.java 71.42% 0 Missing and 2 partials ⚠️
...a/com/networknt/schema/PropertyNamesValidator.java 60.00% 0 Missing and 2 partials ⚠️
...main/java/com/networknt/schema/AllOfValidator.java 83.33% 0 Missing and 1 partial ⚠️
...main/java/com/networknt/schema/AnyOfValidator.java 94.73% 0 Missing and 1 partial ⚠️
...ava/com/networknt/schema/ItemsValidator202012.java 80.00% 0 Missing and 1 partial ⚠️
...main/java/com/networknt/schema/OneOfValidator.java 90.90% 0 Missing and 1 partial ⚠️
...ava/com/networknt/schema/PrefixItemsValidator.java 80.00% 0 Missing and 1 partial ⚠️
...java/com/networknt/schema/PropertiesValidator.java 92.85% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #966      +/-   ##
============================================
- Coverage     78.78%   78.63%   -0.16%     
- Complexity     1768     1809      +41     
============================================
  Files           160      161       +1     
  Lines          5798     5893      +95     
  Branches       1081     1116      +35     
============================================
+ Hits           4568     4634      +66     
- Misses          825      833       +8     
- Partials        405      426      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 1f60740 into networknt:master Feb 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants