Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for type integer #954

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Add test for type integer #954

merged 1 commit into from
Feb 6, 2024

Conversation

justin-tay
Copy link
Contributor

Closes #864

Adds a test to verify this issue is fixed.

This was fixed in 1834353 in 1.0.83.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51fd82b) 78.98% compared to head (ad741d8) 78.98%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #954   +/-   ##
=========================================
  Coverage     78.98%   78.98%           
  Complexity     1717     1717           
=========================================
  Files           157      157           
  Lines          5715     5715           
  Branches       1079     1079           
=========================================
  Hits           4514     4514           
  Misses          802      802           
  Partials        399      399           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit fb40864 into networknt:master Feb 6, 2024
4 checks passed
@justin-tay justin-tay deleted the gh864 branch February 20, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect integer comparison as per JSON Schema spec
3 participants