Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects treating 1.0 as an integer #707

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

fdutton
Copy link
Contributor

@fdutton fdutton commented Apr 12, 2023

While investigating the issue, I found a previous refactoring left behind a large quantity of duplicated code. This has been removed.

@codecov-commenter
Copy link

Codecov Report

Merging #707 (708a04e) into master (636a346) will increase coverage by 1.52%.
The diff coverage is 96.77%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##             master     #707      +/-   ##
============================================
+ Coverage     73.91%   75.43%   +1.52%     
+ Complexity     1086     1078       -8     
============================================
  Files           105      105              
  Lines          3876     3778      -98     
  Branches        803      757      -46     
============================================
- Hits           2865     2850      -15     
+ Misses          703      639      -64     
+ Partials        308      289      -19     
Impacted Files Coverage Δ
...n/java/com/networknt/schema/ValidationContext.java 84.78% <ø> (ø)
...java/com/networknt/schema/SpecVersionDetector.java 95.83% <91.66%> (-4.17%) ⬇️
...om/networknt/schema/ExclusiveMaximumValidator.java 41.86% <100.00%> (ø)
...om/networknt/schema/ExclusiveMinimumValidator.java 41.86% <100.00%> (ø)
...in/java/com/networknt/schema/MaximumValidator.java 70.21% <100.00%> (ø)
...in/java/com/networknt/schema/MinimumValidator.java 70.21% <100.00%> (ø)
.../main/java/com/networknt/schema/TypeValidator.java 100.00% <100.00%> (+38.01%) ⬆️
.../java/com/networknt/schema/utils/JsonNodeUtil.java 62.29% <100.00%> (+26.58%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@stevehu stevehu merged commit 460526d into networknt:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants