Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize hasAdjacentKeywordInEvaluationPath #1092

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

justin-tay
Copy link
Contributor

Closes #1091

This optimizes the hasAdjacentKeywordInEvaluationPath function by attempting to detect when the instanceLocation changes as it is really trying to find the adjacent keywords to the instance location for use later during annotation processing.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.08%. Comparing base (48ca3c2) to head (990b561).
Report is 51 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1092      +/-   ##
============================================
- Coverage     78.90%   78.08%   -0.82%     
- Complexity     1965     2070     +105     
============================================
  Files           172      201      +29     
  Lines          6352     6886     +534     
  Branches       1255     1265      +10     
============================================
+ Hits           5012     5377     +365     
- Misses          867     1036     +169     
  Partials        473      473              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit a9e8a49 into networknt:master Jul 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exponential algorithm in BaseJsonValidator.hasAdjacentKeywordInEvaluationPath
3 participants