Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance and fixes #1086

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

justin-tay
Copy link
Contributor

Closes #1082

Adds some possible performance improvements and fixes an issue with resolve

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.12%. Comparing base (48ca3c2) to head (ae876e4).
Report is 46 commits behind head on master.

Files Patch % Lines
...main/java/com/networknt/schema/SchemaLocation.java 91.30% 0 Missing and 2 partials ⚠️
src/main/java/com/networknt/schema/JsonSchema.java 66.66% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1086      +/-   ##
============================================
- Coverage     78.90%   78.12%   -0.78%     
- Complexity     1965     2070     +105     
============================================
  Files           172      201      +29     
  Lines          6352     6894     +542     
  Branches       1255     1265      +10     
============================================
+ Hits           5012     5386     +374     
- Misses          867     1032     +165     
- Partials        473      476       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit c8bfc83 into networknt:master Jul 5, 2024
4 checks passed
@justin-tay justin-tay deleted the jsonnodepathperf branch July 5, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible performance improvement: JsonNodePath.hashCode()
3 participants