Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix evaluationPath and schemaLocation in getSubSchema #1081

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

justin-tay
Copy link
Contributor

Fix evaluationPath and schemaLocation in getSubSchema when having a number in fragment due to SchemaLocation.of parsing.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (48ca3c2) to head (2285db0).
Report is 46 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1081      +/-   ##
============================================
- Coverage     78.90%   78.04%   -0.86%     
- Complexity     1965     2065     +100     
============================================
  Files           172      201      +29     
  Lines          6352     6879     +527     
  Branches       1255     1257       +2     
============================================
+ Hits           5012     5369     +357     
- Misses          867     1032     +165     
- Partials        473      478       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 8fc6913 into networknt:master Jul 5, 2024
4 checks passed
@justin-tay justin-tay deleted the fixsubschema branch July 5, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants