Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix oneOf when discriminator enabled but no discriminator #1078

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

justin-tay
Copy link
Contributor

Fixes issue when oneOf when discriminator enabled but no discriminator causes no details in errors. Such cases should behave as a normal oneOf.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.98%. Comparing base (48ca3c2) to head (ebb2b65).
Report is 42 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1078      +/-   ##
============================================
- Coverage     78.90%   77.98%   -0.92%     
- Complexity     1965     2053      +88     
============================================
  Files           172      198      +26     
  Lines          6352     6855     +503     
  Branches       1255     1257       +2     
============================================
+ Hits           5012     5346     +334     
- Misses          867     1032     +165     
- Partials        473      477       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit bbbbd1c into networknt:master Jul 1, 2024
4 checks passed
@justin-tay justin-tay deleted the oneofdiscriminator branch July 1, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants