Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iri, iri-reference, uri and uri-reference #1071

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

justin-tay
Copy link
Contributor

@justin-tay justin-tay commented Jun 21, 2024

Closes #1070

This fixes iri, iri-reference, uri and uri-reference formats to allow inputs conforming to RFC 3986 / RFC 3987 for which URI will throw a syntax error as it implements RFC 2396.

In particular inputs like http://, // and about: are now accepted.

A more complete and proper fix will likely require an additional library like Apache Jena IRI but will defer this until it is really needed.

@stevehu stevehu merged commit b93a66e into networknt:master Jun 21, 2024
4 checks passed
@justin-tay justin-tay deleted the gh1070 branch July 2, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"http://" should be considered as a valid iri-reference
2 participants