Improve documentation on regular expressions #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1066 +/- ##
============================================
- Coverage 78.90% 78.68% -0.22%
- Complexity 1965 2053 +88
============================================
Files 172 198 +26
Lines 6352 6635 +283
Branches 1255 1249 -6
============================================
+ Hits 5012 5221 +209
- Misses 867 936 +69
- Partials 473 478 +5 ☔ View full report in Codecov by Sentry. |
stevehu
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the documentation on regular expressions and adds additional tests.
Disabled tests for the current issue for not properly matching anchors when there are newlines have been added for the JDK and Joni implementations. The tests show that GraalJS works. Tests also added that ensures that there is no implicit anchoring is used.